Development :  K-Meleon Web Browser Forum
K-Meleon development related discussions. 
adblock toggle in current page only - how?? (KM1.6)
Posted by: siria
Date: June 26, 2011 07:25AM

Hi, since currently there are so many savvy programmers around, finally a question:
could anyone please tell me some fix how to get adblock-toggle working on the current page only??

Until KM1.5.4 that was the normal behaviour, but since 1.6 (=new gecko) that thing toggles ALL tabs in the whole window, which takes forever on my old machine, and hate that, since it's completely unnecessary in most cases. Just wanna do a quick check for false positives on current page! :mad:

This is one of the few remaining im-worsements in 1.6beta that still drive me crazy and still don't have any workaround yet - ARGH!

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: disrupted
Date: June 26, 2011 12:53PM

you will need to enable the statusbar icon, right click on it and select disable on this page only or the entire domain or by creating an exception filter for selected blockable items that affect page features. you can select report issue on this page so it can be excluded/updated in the subscription

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: siria
Date: June 27, 2011 07:14PM

Thanks for responding, but forgot to mention, I don't mean Adblock "Plus", just the built-in mini adblocker. That always worked well enough for me smiling smiley (until it started toggling the whole window)

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: disrupted
Date: June 27, 2011 08:20PM

oops sorry. can't help there

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: deadlock
Date: June 28, 2011 04:54PM

@siria
>get adblock-toggle working on the current page only?
>Until KM1.5.4 that was the normal behaviour, but since 1.6 (=new gecko)

Did you test KM 1.6b2 with old 1.5.4 chrome and 1.5.4 config?
Disk-Cache enabled?

>that thing toggles ALL tabs in the whole window,

I have '/Tools/Privacy/Block Advertisement' in my menu.
Never enabled this option before and there is no reload
if i enable or disable this option.

Can you upload a minimal configuration for testing? (~dhost)
It should be only big enough to reproduce this problem.

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: siria
Date: June 28, 2011 06:52PM

To reproduce, just take a brandnew portable 16beta2, with a brandnew profile. All native.
Open a couple KM pages in tabs, forum, wiki, whatever.

Now open adblock.css (Edit>Config>Ad-Blocking) and add the forum image from the left side:
img[src*="kmelogo.gif"],

Toggle adblock off/on to import the updated css-file.
The image appears or vanishes on ALL pages at the moment of toggling adblock, they are not "reloaded" but all "reflowed" (or whatever that's called) automatically.

Of course those are very simple example pages where toggling works in split seconds, but when I have a session with 30+ tabs and some "heavier" sites, the toggling takes audibly an enormous effort for my poor old box for some seconds ;-)

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: deadlock
Date: June 29, 2011 05:46PM

@siria
>brandnew portable 16beta2, with a brandnew profile. All native.
Got it working with my old profiles.
Worked with F5-refresh but not automatically.
Enabling and disabling some Javascript-options
enabled immediate switching in KM 1.54 and KM 1.6.

>open adblock.css (Edit>Config>Ad-Blocking)
It is called 'Edit->Configuration->Ad-Blocking StyleSheet' here.
Added logo in 'display: none'-block.
Does it take more time to disable or to enable Ad-Blocking?

>'heavier' sites, the toggling takes audibly an enormous effort

This may be the same annoying mechanism,
that updates favicons of inactive tabs.

It will take some time to find the changed part.
Fred could test with his multi-version builds.

Just found out, that FF favours favicons over siteicons.
Should KM do that too? Now it sometimes switches them.

Update:
Tested KM 1.6 with chrome and config from 1.54 without success.
GRE or K-Meleon.exe itself may be responsible.



Edited 1 time(s). Last edit at 06/29/2011 07:34PM by deadlock.

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: siria
Date: July 01, 2011 09:02PM

Quote
deadlock
Worked with F5-refresh but not automatically.
Enabling and disabling some Javascript-options
enabled immediate switching in KM 1.54 and KM 1.6.

Interesting - which options were that? <curious>

If disabling or enabling takes more time, not sure, but guess both actions usually "feel" rather similar time-wise.

Quote
deadlock
Tested KM 1.6 with chrome and config from 1.54 without success.
GRE or K-Meleon.exe itself may be responsible.

My suspicion has always been that it's a gecko thing, simply because it has happened from the start of the 1.6 test versions, and at that point the devs were way too busy with getting crucial bugs fixed that I could imagine them playing with such gimmicks ;-)

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: deadlock
Date: July 02, 2011 06:40PM

Quote
siria
Quote
deadlock
Worked with F5-refresh but not automatically.

Enabling and disabling some Javascript-options
enabled immediate switching in KM 1.54 and KM 1.6.

Interesting - which options were that? <curious>

Sorry, tried everything, with backups, but can't reproduce.
I thought it was allow hiding or something similar.

Quote
siria
If disabling or enabling takes more time, not sure, but guess both actions usually 'feel' rather similar time-wise.

There is no Internet access while switching and
the slowest memory eating part in KM is its GRE.

Another possibility:
If window creation in KM 1.6. changed, and they're
now built dependent, they receive the same messages.

Quote
siria
My suspicion has always been that it's a gecko thing,

Then download both Geckos and compare. grinning smiley
I'm still busy with favicons and if any KM-Code
is involved it will show up while disabling functions for testing.

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: disrupted
Date: July 10, 2011 06:10PM

this line should be added to the whitelist

img[src*="addons.mozilla.net/"],

affects screenshots on some AMO pages https://addons.mozilla.org/en-US/firefox/addon/seoquake-seo-extension/

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: siria
Date: July 10, 2011 06:33PM

Speaking of whitelist, I recently struggled but found no way to whitelist that image here:
http://en.wikipedia.org/wiki/Deborah_Sampson
Tried with:
img[src^="http://upload.wiki"],
img[src*="-public-library"],

But no way. What am I doing wrong, anyone enlighten me??

For now I've decided, to not miss false positives but not get bothered with ads either, to just minimize them and put a red dotted border around, instead of setting the blacklist completely invisible :cool:
height: 16px !important; width: 20px !important; border: 3px dotted red !important;
Will test that for awhile, if I like it or perhaps it starts getting on my nerves ;-)



Edited 1 time(s). Last edit at 07/10/2011 06:35PM by siria.

Options: ReplyQuote
Re: adblock toggle in current page only - how?? (KM1.6)
Posted by: disrupted
Date: July 10, 2011 07:15PM

delete this line:

*[src*="publicad"][src*="ad"],

won't have much affect

Options: ReplyQuote


K-Meleon forum is powered by Phorum.