It's all OK for me there, duffy! I cannot reproduce your trouble...

Thanks rodocop for verifying that link. That's strange that I get those squares instead of checkmarks. Any ideas or settings suggestions? I'd appreciate if some others who also have KM Twin installed would try that link to see what results they get. Maybe a few people might have the same result as myself or if nobody has squares and only "green check marks" as you have ... then it will seem to be an isolated case only happening on my machine. Anyway, thanks and I will look some settings over, although I really don't have a clue at this point as to what to look for.

mike



Edited 1 time(s). Last edit at 12/30/2012 07:31PM by duffy98.

@ rodocop

I have made some incremental improvements in SkinPreLd.kmm and SkinSwitch.kmm macros.

Change log

SkinPreLd

1.  Fixed a missing brace in the code.
2.  Now reports the number of items loaded from skin.dat.

SkinSwitch

1.  Now has direct call to restart.kmm instead of code in SkinSwitch.
2.  Changed wording on menu to reflect current mission.
3.  Changed wording in macroinfo statements to reflect change 2.
4.  Changed saved skin layout filename by adding "-skin" to the skin name.
    This was done to allow beter filtering in when the user wishes to select 
    a skin layout file.  Previous filter allowed all .ini files where the 
    change will show only *-skin.ini file.  Files for other purposes which
    have the extention ini will not display for selection.

    If you have current < skin name >.ini files, you can rename them in the
    form < skin name >-skin.ini.  Example below:
    Klassic.ini becomes Klassic-skin.ini

SkinPreLd 2.1 https://dl.dropbox.com/u/1522294/SkinPreLd2dot1.7z

SkinSwitch 2.7 https://dl.dropbox.com/u/1522294/SkinSwitch2dot7.7z

Unless someone finds a problem, I hope these are finished now.

The big, remaining question is how to explain to a new user why and how they should this skin changing system.

Hanlon’s razor is an eponymous adage named after Robert J. Hanlon that states: “Never attribute to malice that which is adequately explained by stupidity.”

JamesD

Thank you, James!
I'll try to write some words about this tool.

And then our new goal will be to create new menu item in Help where all new advanced features would be described.

It will be what to do in the new year!

could u add Chinese into next build, there are some bugs, when add a new page.

and Chinese package is here.

http://kmeleonbrowser.org/forum/read.php?2,120143



Edited 1 time(s). Last edit at 01/01/2013 03:18AM by chinarobin.

Quote
Myself
Unless someone finds a problem, I hope these are finished now.

Well, I found a problem. I was reading the wrong file for the default prefs. The file root\defaults\prefile.js is not the one read by KM. The correct file is root\defaults\pref\skin.js. So here are corrected versions of SkinSwitch.js and SkinSwitch.kmm.

https://dl.dropbox.com/u/1522294/SkinSwitch.7z

Note, to save space I deleted the old SkinSwitch stuff in my dropbox account.

Hanlon’s razor is an eponymous adage named after Robert J. Hanlon that states: “Never attribute to malice that which is adequately explained by stupidity.”

JamesD

Quote
JamesD
Well, I found a problem. I was reading the wrong file for the default prefs. The file root\defaults\prefile.js is not the one read by KM.

prefile.js is a typo, the used string was:
SkinSwitch_Root_Path + '\\defaults\\prefskin.js' ;

Interesting:
prefskin.js didn't exist in KM 0.7.
prefskin.js was seen in official KM version in 2008.
prefskin.js isn't used by KM 1.6 CVS sources.
prefskin.js isn't referenced in official KM 1.6 package.

Maybe it was used by a previous version or a kmext tool
one of the team members used while preparing a release.

My best guess is, that it was used as an example
for skin.js creation and should be deleted.



Edited 1 time(s). Last edit at 01/03/2013 09:39PM by deadlock.

Quote
deadlock
Interesting:
prefskin.js didn't exist in KM 0.7.
prefskin.js was seen in official KM version in 2008.
prefskin.js isn't used by KM 1.6 CVS sources.
prefskin.js isn't referenced in official KM 1.6 package.
...
My best guess is, that it was used as an example
for skin.js creation and should be deleted.

Thank you for historical review - it was one of my questions about defaults.

Quote
deadlock

Quote
JamesD
Well, I found a problem. I was reading the wrong file for the default prefs. The file root\defaults\prefile.js is not the one read by KM.


prefile.js is a typo, the used string was:
SkinSwitch_Root_Path + '\\defaults\\prefskin.js' ;

It was not a typo. I was just plain reading the wrong file. The corrected line in SwitchSkin.js now has "SkinSwitch_Root_Path + "\\defaults\\pref\\skin.js" ;"

As I told Rodocop by e-mail, I ran this test.

Quote

I had used prefskin.js in the defaults folder for SkinSwitch, but was that right? Just to check I put extra prefs in each file. I put pref("kmeleon.toolband.ExtraPrefSkin.visibility", false); into the prefskin.js file and I put pref("kmeleon.toolband.ExtraSkin.visibility", false); into the skin.js file. I then ran my KM and did an edit on the configuration with a filter of Extra. I only saw kmeleon.toolband.ExtraSkin.visibility. I used the wrong file in SwitchSkin. It was a very simple fix to have SwitchSkin.js read the correct file.

If I ever create another version, I will definitely leave prefskin.js out of it.

Hanlon’s razor is an eponymous adage named after Robert J. Hanlon that states: “Never attribute to malice that which is adequately explained by stupidity.”

JamesD

Deadlock found a bug in the SkinSwitch.js file. It seems one toolbar name contains a string of 3 dots. Since I had used the dot as a delimiter, I had to account for that one toolbar. The revised SkinSwitch system can be downloaded from:
https://dl.dropbox.com/u/1522294/SkinSwitch.7z

Hanlon’s razor is an eponymous adage named after Robert J. Hanlon that states: “Never attribute to malice that which is adequately explained by stupidity.”

JamesD