Any submenu, separator, macro or command ID under bookmarks() in menus.cfg disappears in the drop-down menu bookmarks list after editing bookmarks until next startup. Can anyone else reproduce this? In example text below, after editing bookmarks in KM, Bookmark Groups disappears until KM is restarted.

%ifplugin bookmarks
&Bookmarks {
:&Menu
-
macros(bookmark_add)
macros(qfs, Search Bookmarks)
bookmarks(Edit, &Manage bookmarks)
bookmarks(Config, &Bookmarks settings)
bookmarks()
-
:&Bookmark Groups
}
%endif

jsnj:

I get the same exact thing. This also happens if you have an exit button or anything else underneath it, not just with a menu like the &Bookmark Groups menu. I had to move my other menus / menu items to above the bookmarks() call so they wouldn't disappear after editing the bookmarks.

Also, some related funky activity, is that if you have bookmarks() in a different place (let's say in &Main), and in the regular place under &Bookmarks; and exact duplicate of your bookmarks root folder is created. For example, my booksmarks are like this:

All Bookmarks +
.......................|
.......................--- Bookmarks +


But when I put bookmarks() in &Main, then it looks like this:

All Bookmarks +
.......................|
.......................--- Bookmarks +
.......................|
.......................--- Bookmarks (exact copy) +


Wierd....


Shelumi`El
Jordan

S.D.G

To file a bug on it, is it a bookmarks.dll problem or a k-meleon.exe problem?

jsnj,

I would say bookmarks since the bookmarks menus are created by the bookmarks plugin.

Yes, I think it is a bookmarks bug also. I will test a bit and see if happens with the other "bookmark" plugins (favorites, hotlist) too. I'll fill out a bug report encompassing all of them if the bug applies to them all.


Shelumi`El
Jordan

S.D.G

I filed bug 440 a few hours ago on what I mentioned above. Please add anything more comprehensive to it if need be.

jsnj:

I just found out why looking through some of the bookmarks code...

In \ns_bookmarks\ns_bookmarks_utils.cpp:

void Rebuild() {
// delete the old bookmarks from the menu (FIXME - needs to be more robust than "delete everything after the first bookmark position" - there may be normal menu items there (if the user is weird))
while (DeleteMenu(gMenuBookmarks, nFirstBookmarkPosition, MF_BYPOSITION));
// ...


I don't know about fixing this over in DeleteMenu, but I'll have a look over the next few days and let you know if I figure out anything.


Shelumi`El
Jordan

S.D.G