MonkeeSage, Can you build the plugins with M$VC and see if the size decreases, particularly toolbars since it was a big jump (doubling in size is definitely bad).
Forum: General

MonkeeSage, Can you build a version of the current bookmarks.dll but without that new backup code. I hate automatic backups, I don't need help backing up my system.
Forum: General

MonkeeSage, My toolbars change works though toolbars.dll over doubled in size (from 11776 bytes to 24576 bytes). Adding two small while loops definitely doesn't account for 12.5k increase in size.
Forum: General

MonkeeSage, I have a possible fix for bug 382 but I'm not 100% sure of this and need to test it. In toolbars\toolbars.cpp, functions IsButtonEnabled and IsButtonChecked In function IsButtonEnable change: return SendMessage(pToolbar->hWnd, TB_ISBUTTONENABLED, pButton->iID, 0) != 0; to: while (pToolbar) { if (pToolbar->hwndWindow == GetActiveWindow()) return Sen
Forum: General

Minor change - in ns_bookmarks\defines.h Change: #define PREFERENCE_EDIT_ZOOM _T("kmeleon.plugins.favorites.editdialog.zoom") #define PREFERENCE_EDIT_MAX _T("kmeleon.plugins.favorites.editdialog.maximized") to: #define PREFERENCE_EDIT_ZOOM "kmeleon.plugins.bookmarks.editdialog.zoom" #define PREFERENCE_EDIT_MAX "kmeleon.plugins.bookmarks.editdialo
Forum: General

jsnj and MonkeeSage, Did you mention bug 406 ? Ulf just fixed it for all 3 bookmarking plugins. Another rebuild from CVS is needed. I use the dropdown menu myself via Alt-B though I don't use bmpmenu since I don't like extra graphics. What happened with the toolbars button dropdown menu code ?
Forum: General

MonkeeSage, Everything works and including the appearance of the new groupmarks folder item. Is there a way to make the title icon use the existing folder icon resource ? I'm guessing not since M$ generally doesn't care about optimizations. Since the icon is the size issue then maybe the Intel complier isn't bad. Is the Intel compiler freely available ? I heard rumors that the lat
Forum: General

MonkeeSage, 30k for an icon ?!? That ain't good, could you put back the original windows icon in that case ?
Forum: General

MonkeeSage, This time I got an even big .dll (98304 bytes). I'm guessing that's not right, that's a 50% overall increase in size. I redownloaded the last beta .dll and it's only 62464 bytes.
Forum: General

MonkeeSage, I just downloaded bookmarks.dll and it was the exact same ICC .dll as before.
Forum: General

MonkeeSage, Everything works in the new bookmarks plugins but the Intel complier sucks, the relative code size increase of 40% is too much. I would hate to see what it did to a typical program with a size in megabytes not kilobytes. As for MMX/SSE/SSE2 optimizations, as an assembly language I can tell you that stuff makes very little difference to most programs, it helps much more for graphics a
Forum: General

MonkeeSage, That's certainly a possibility but then why does it only happen with new foreground windows and not all the time.
Forum: General

MonkeeSage, I just downloaded bookmarks.dll and the search issue is still there and it still has the star icon. Also it grew from 62464 bytes to 88064 bytes, 40% increase in size.
Forum: General

I suspect the focus is being stolen for new foreground windows when the HTML page itself is completely loaded even though all of the graphics on the page may not be loaded.
Forum: General

MonkeeSage, Is that the last issue in the new bookmarks ? If so I suppose bookmarks-beta.dll can be made the distribution version.
Forum: General

MonkeeSage, About the focus stealing problem, focus is stolen for a new foreground window during page loading. I've had this occur and saw the page was still rendering. I originally thought it had to do with windows messages but now I don't think so. I now suspect it's something the Mozilla code is doing that's causing the focus to be grabbed twice for new foreground windows
Forum: General

MonkeeSage, For the check menu items issue, in ns_bookmarks_edit.cpp function OnRClick change: CBookmarkNode *node = GetBookmarkNode(hTree, hItem); if (node && node->type != BOOKMARK_FOLDER) { HTREEITEM htiParent = TreeView_GetParent(hTree, hItem); if (htiParent) node = GetBookmarkNode(hTree, htiParent); else node = NULL
Forum: General

jsnj, I get the same thing, you have to setup some browser type prefs to make it not do that. You can save the file with Ctrl-S once it's loaded or goto the disk cache (about:cache?device=disk), find the entry, click on it to get info and right click on the link from there.
Forum: General

MonkeeSage, Latest bookmarks works better now, window is non-modal and focus is properly returned on Escape. As for the "Set as ..." items being checked, this happens for entries in the root folder because of new code in ns_bookmarks_utils.cpp function OnRClick: if (node && node->type != BOOKMARK_FOLDER) { HTREEITEM htiParent = TreeView_GetParent(hTree, hIte
Forum: General

MonkeeSage, Variable hWndFront was always null since it was never set. Try adding the following code to ns_bookmarks_util in callback function WndProc: (you already got the second part) if (message == WM_SETFOCUS) hWndFront = hWnd; else if (message == WM_COMMAND) { ... else if (command == wm_deferbringtotop) { BringWindowToTop(hWnd); return true; }
Forum: General

MonkeeSage, This is the code that should do the trick unless hWndFront is somehow NULL, though the edit window that I got was modal. I think if the modality issue was solved then this would work properly. hWndFront should be the previous window so posting the message wm_deferbringtop should bring it to the top. if (hWndFront) PostMessage(hWndFront, WM_COMMAND, w
Forum: General

MonkeeSage, Delete removes the bookmark entry structure so if they all get deleted then the saved bookmarks file will have no entries. I'll go through CVS and see if I can find the update made to fix the focus problem in the history plugin.
Forum: General

jsnj, About the bookmarks search, a full fledged search (via Ctrl-F or F3) sounds like a better idea, then the original first letter search can be restored. You should open an RFE for this against bookmarks and mention that it should apply to favorites and hotlist as well. fullscreen.dll is there but there's no link on his page (yet) - http://monkeesage.d2g.com/fullscreen.dll
Forum: General

MonkeeSage, Try pulling the bookmarks code again since Ulf has been a busy programmer. The bookmarks I downloaded from your page was modal as before with no program bar entry but did have the find stuff. Actually I don't think the incremental find stuff is all that great for the bookmarks but I don't have many bookmarks and find first letter access easier, no biggie though since I gene
Forum: General

MonkeeSage, The bookmarks plugin is still modal and there are other issues as well. You should pull this build for now and put back the previous one until stuff is resolved.
Forum: Bugs

MonkeeSage, The new bookmarks plugins has a couple of problems: - It's still modal and worse pressing Esc doesn't return focus to the previous browser window (did you put up Ulf's build ? It looked non-modal from the code) - All of the "Set as ..." items on the right click menu are always checked. As for the icon, the star reminds me too much of Opera (yuck). For now
Forum: General

So far Ulf has updated bookmarks, favorites, fullscreen, history, hotlist, and toolbars. No changes to the main program as of yet.
Forum: General

MonkeeSage, Don't update the plugins just yet, Ulf is making a bunch of changes. The bookmarks plugin has a lot of changes, from what I can tell the bookmarks edit window is no longer modal but a real window, it now has incremental search, Mozilla bookmark groups are supported, my status bar and bookmark alignment fix are there as well. The favorites and hotlist have some minor updates as w
Forum: General

Uhm <DD> in bookmarks ? That's certainly new to me, as far as I know bookmarks only use <DT> and <A> with the following tags: HREF="url" ADD_DATE="time" LAST_VISIT="time" LAST_MODIFIED="time" LAST_CHARSET="charset" (Mozilla) SHORTCUTURL="nick" (Mozilla) ALIASID="num" (leftover from NS 3 address book) ALI
Forum: Bugs

By the way speaking of the gutter, you're already there. Lets goto the videotape so to speak: http://kmeleonbrowser.org/forum/read.php?f=4&i=3633&t=3633 If you didn't constantly spout off and rant on and on about the bookmarks then maybe you wouldn't elict such a negative response.
Forum: Bugs