MonkeeSage, The new compile was exactly the same. Anyway it seems unstable, sometimes it works and sometimes it doesn't. It should work since I'm pretty sure the code logic is correct. The only possible issue I can see is that I'm directly modifying a "cstring" (*q = 0 and *q = ' ') and maybe you're not supposed to do that ? Why can't c++ always use n
Forum: General

MonkeeSage, That doesn't work for me, I get the error message "The URL is not valid and cannot be loaded" for custom keywords with parameters and I also got a crash once. Back that change out and restore the original bookmark keywords code.
Forum: General

Here is an implementation of bookmark keywords substitution (%s) that should work the same as in Mozilla: BrowserView.cpp (bug 289 - bookmark keywords) --------------- #include "kmeleon_plugin.h" #include <wininet.h> void CBrowserView::OnNewUrlEnteredInUrlBar() { char *p, *q, *r; char nickUrl; char custUrl; mpBrowserFrame->m_wndUrlBar.EditChanged(FALSE); ns
Forum: General

MonkeeSage, I verified that the autoscrolling rate is faster than before. I guess the DOM functions use a different scale than the nsIScrollable functions.
Forum: General

MonkeeSage, I downloaded the updated .exe and everything works. I downloaded a diff utility and the current K-Meleon source so I can make diffs for all of my fixes and send them to the devs.
Forum: General

Could you post when you've updated the .exe with the fixes for 28, 281, and 433 (prefs panel). We should see about getting all of our fixes into the official build.
Forum: General

I opened bug 433 for this issue.
Forum: General

I don't have any other ideas for fixing bugs 28 and 29 at this time so the original OnTimer code should remain as is for now but I do have an idea for fixing bug 281 (moving mousewheel doesn't cancel autoscroll) BOOL CBrowserView:reTranslateMessage(MSG* pMsg) { if(m_panning && (pMsg->message==WM_SETCURSOR || pMsg->message==WM_MOUSEMOVE)) return TRUE; if(m_pannin
Forum: General

I came up with a better idea, the Default entry should be inherit in the code and always use general.useragent.override, this allows that pref to be directly edited via the panel and you'll always be able to see it. If it's not set then Default will be blank as always. Note with this change the kmeleon.privacy.useragent0 prefs will never be used but the others (kmeleon.privacy.useragent
Forum: General

Actually it has to be the newer code for two reasons - kmeleon.privacy.useragent0.name doesn't necessarily have to be "Default" and if you scroll down and back up in the list that entry will then appear as blank or whatever kmeleon.privacy.useragent0.string is set to anyway.
Forum: General

MonkeeSage, Well which do you think is better in the case of a custom useragent string - initially displaying a blank entry in the list combo box or Default ?
Forum: General

On second thought maybe it should be left as in my original fix. If someone manually set the string then they likely wouldn't be using the prefs menu anyway. In any case once the combo box is activated, blank entry will never reappear so it probably shouldn't appear in the first place which is what the newer code would do for a custom useragent string.
Forum: General

Minor change for the case of a custom useragent string: BOOL CPreferencePage::OnInitDialog(){ switch (idd) { case IDD_PREFERENCES_PRIVACY: char buf[256], uabuf[256], pref[34]; int x=0,y,index=-1; do { sprintf(pref, "kmeleon.privacy.useragent%d.name", x); theApp.preferences.GetString(pref, buf, ""); if (*
Forum: General

Currently in the Prefs - Privacy panel, the browser identification is blank until the list is accessed and if the value is changed then the next time K-Meleon is started this isn't reflected in the prefs panel. This change to PreferencesDlg.cpp should fix that, note the char variable pref must be 34 not 32 for kmeleon.privacy.useragent%d.string which is why the routine OnComboChanged is affe
Forum: General

Also try GetDOMWindow instead of GetContentDOMWindow
Forum: General

On the issue of accelerators here's a minor update - currently the pgup and pgdn keys are VK_PRIOR and VK_NEXT (apparently a win32 thing). There should be aliases VK_PAGE_UP and VK_PAGE_DOWN. Adding the following to AccelParser.cpp addresses this (bug 376): After the VK_OEM definitions add: #define VK_PAGE_UP VK_PRIOR #define VK_PAGE_DOWN VK_NEXT and in routine Parse: VK_TEST
Forum: General

jsnj, I just looked at the mozdev autoscroll source and it's all done via javascript and that wretched xul garbage so it's even lamer than I first thought. MonkeeSage, The function I mentioned should be GetOwnerDocument, that is what's used in BrowserFrameGlue to ultimately get the current frame URL.
Forum: General

MonkeeSage, The index numbers are assigned in toolbar creation order so the URL bar will always be first (0) and the throbber second (1), then the plugins, most likely in the order they are in the kplugins subdirectory.
Forum: General

MonkeeSage, In accel.cfg use the values 2000 - 2049 instead of ID strings. In my setup I have the menu bar (which is static) and on the next row, the toolbar (back,forward,reload,stop), url bar, and throbber. 2000 = url bar, 2001 = throbber, 2002 = tool bar. So ALT 1 = 2002 in accel.cfg toggles the tool bar. I have no idea (yet) what the deal is with the order. In prefs.js they're in scree
Forum: General

One other thing, it is easier codewise to simply not strip the %s for normal bookmark access. I suppose custom keyword bookmarks can be kept in a separate folder.
Forum: General

jsnj, The code itself isn't too complex, mainly a bunch a string functions. I don't like the fact %s precludes a bookmark from being used normally. Most search sites will bring up a default search page and other sites which use parameters will use a default value if nothing is specified (generally this will be a trailing =). I would be inclined to strip the %s if not accessed via a sho
Forum: General

That's lame especially considering typeahead find scrolls the page correctly to strings/links even within frames. I still think it can be made to work fully in K-Meleon.
Forum: General

Maybe you need to use GetOwnerDoc ?
Forum: General

jsnj, What I don't like about keeping the %s intact is that the bookmark becomes useless as a normal bookmark which is kind of crappy. I'm not sure what you mean by quicksearch but what Mozilla does is this - if you have a shortcut gs for http://www.google.com/search?q=%s then entering gs k-meleon becomes http://www.google.com/search?q=k-meleon
Forum: General

MonkeeSage, Does the middle button autoscrolling work in Mozilla ? If so then maybe it isn't enough to only issue GetContentDOMWindow, maybe you have to check for frames and find the current frame though that doesn't seem very efficient. I'm guessing this might actually be the case because in BrowserView.cpp there's a function to change the font size (ChangeTextSize) and it u
Forum: General

What does Mozilla do if you select a bookmark with %s in it ? Does it open the URL with the %s intact or is the %s removed ?
Forum: General

MonkeeSage and jsnj, I thought of a way to implement custom keywords but a few points: - Selecting a bookmark with %s normally (menu or bookmark editor) will actually open the URL verbatim, with the %s included (I assume this is what Mozilla will do as well). This seems like a flaw in the custom keywords scheme. - It will only work with Netscape/Mozilla bookmarks since Opera has no such substi
Forum: General

In BrowserViewPanning.cpp scrolling is currently done using functions from nsIScrollable (GetCursorPos, GetCurScrollPos, SetCurScrollPosEx). I think if there's a way to get the current DOM window (or frame) and use the functions from nsIDOMWindow (GetScrollX, GetScrollY, ScrollTo or ScrollBy) instead then auto-scrolling should work for frames (bug 29) and the crash bug (bug 28) should be fix
Forum: General

If you want to import your bookmarks then there is a COPY command (internal to COMMAND.COM) and an XCOPY command and of course you can use the kludgey windows gui to copy files. K-Meleon can read Netscape 4.x or Mozilla bookmarks (and IE favorites and Opera hotlist). K-Meleon is supposed to be a lightweight browser and importing is NOT technically a browser function so stop whining about it and c
Forum: Bugs

Andrew, Is the error with watched bugs going to be fixed any time soon ?? Also I don't think the bug change detection is fully working. If a new bug is created then a search for new bugs within the last day shows it but if a bug is updated then it doesn't show up in the same search.
Forum: Bugs